maya-chen/flask
1
0
Fork 0
forked from orbit-oss/flask
Code Pull requests Activity

wait until app ctx is ready before matching url

Browse source 
`RequestContext.match_request` is moved from `__init__` to `push`. This
causes matching to happen later, when the app context is available.
This enables URL converters that use things such as the database.
This commit is contained in:
Elad Moshe 2019-02-24 23:54:57 +02:00 • committed by David Lord
parent 29111a3259
commit 1ff98a2d21
No known key found for this signature in database
GPG key ID: 7A1C87E3F5BC42A8
4 changed files with 41 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

20
tests/test_basic.py
View file

@ -1384,26 +1384,6 @@ def test_url_for_passes_special_values_to_build_error_handler(app):
flask.url_for("/")
def test_custom_converters(app, client):
from werkzeug.routing import BaseConverter
class ListConverter(BaseConverter):
def to_python(self, value):
return value.split(",")
def to_url(self, value):
base_to_url = super(ListConverter, self).to_url
return ",".join(base_to_url(x) for x in value)
app.url_map.converters["list"] = ListConverter
@app.route("/<list:args>")
def index(args):
return "|".join(args)
assert client.get("/1,2,3").data == b"1|2|3"
def test_static_files(app, client):
rv = client.get("/static/index.html")
assert rv.status_code == 200