maya-chen/flask
1
0
Fork 0
forked from orbit-oss/flask
Code Pull requests Activity

There was a duplicated call to url_adapter.build(...)

Browse source 
try:
        rv = url_adapter.build(endpoint, values, method=method,
                               force_external=external)
    except BuildError, error:
        # We need to inject the values again so that the app callback can
        # deal with that sort of stuff.
        values['_external'] = external
        values['_anchor'] = anchor
        values['_method'] = method
        return appctx.app.handle_url_build_error(error, endpoint, values)

   rv = url_adapter.build(endpoint, values, method=method,
                          force_external=external)

If no exception was raised for url_adapter.build(...) then the same method call
would be made after the try...except block. This is unnecessary.
This commit is contained in:
Mitchell Peabody 2012-10-17 11:56:39 -04:00
parent a15c6c569a
commit 275f830c83
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
flask/helpers.py
View file

@ -295,8 +295,6 @@ def url_for(endpoint, **values):
values['_method'] = method
return appctx.app.handle_url_build_error(error, endpoint, values)
rv = url_adapter.build(endpoint, values, method=method,
force_external=external)
if anchor is not None:
rv += '#' + url_quote(anchor)
return rv