maya-chen/flask
1
0
Fork 0
forked from orbit-oss/flask
Code Pull requests Activity

fix subdomain_matching=False behavior

Browse source
This commit is contained in:
David Lord 2024-11-10 20:13:05 -08:00
parent 07c7d5730a
commit 4995a775df
No known key found for this signature in database
GPG key ID: 43368A7AA8CC5926
5 changed files with 98 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

36
tests/test_blueprints.py
View file

@ -951,7 +951,10 @@ def test_nesting_url_prefixes(
def test_nesting_subdomains(app, client) -> None:
subdomain = "api"
app.subdomain_matching = True
app.config["SERVER_NAME"] = "example.test"
client.allow_subdomain_redirects = True
parent = flask.Blueprint("parent", __name__)
child = flask.Blueprint("child", __name__)
@ -960,42 +963,31 @@ def test_nesting_subdomains(app, client) -> None:
return "child"
parent.register_blueprint(child)
app.register_blueprint(parent, subdomain=subdomain)
client.allow_subdomain_redirects = True
domain_name = "domain.tld"
app.config["SERVER_NAME"] = domain_name
response = client.get("/child/", base_url="http://api." + domain_name)
app.register_blueprint(parent, subdomain="api")
response = client.get("/child/", base_url="http://api.example.test")
assert response.status_code == 200
def test_child_and_parent_subdomain(app, client) -> None:
child_subdomain = "api"
parent_subdomain = "parent"
app.subdomain_matching = True
app.config["SERVER_NAME"] = "example.test"
client.allow_subdomain_redirects = True
parent = flask.Blueprint("parent", __name__)
child = flask.Blueprint("child", __name__, subdomain=child_subdomain)
child = flask.Blueprint("child", __name__, subdomain="api")
@child.route("/")
def index():
return "child"
parent.register_blueprint(child)
app.register_blueprint(parent, subdomain=parent_subdomain)
client.allow_subdomain_redirects = True
domain_name = "domain.tld"
app.config["SERVER_NAME"] = domain_name
response = client.get(
"/", base_url=f"http://{child_subdomain}.{parent_subdomain}.{domain_name}"
)
app.register_blueprint(parent, subdomain="parent")
response = client.get("/", base_url="http://api.parent.example.test")
assert response.status_code == 200
response = client.get("/", base_url=f"http://{parent_subdomain}.{domain_name}")
response = client.get("/", base_url="http://parent.example.test")
assert response.status_code == 404