Merge pull request #3243 from DiegoAlbertoTorres/docs

Guard against missing request context in logging docs.
This commit is contained in:
David Lord 2019-05-31 16:47:32 -04:00 committed by GitHub
commit 6369537a49
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -117,13 +117,18 @@ your own fields that can be used in messages. You can change the formatter for
Flask's default handler, the mail handler defined above, or any other Flask's default handler, the mail handler defined above, or any other
handler. :: handler. ::
from flask import request from flask import has_request_context, request
from flask.logging import default_handler from flask.logging import default_handler
class RequestFormatter(logging.Formatter): class RequestFormatter(logging.Formatter):
def format(self, record): def format(self, record):
record.url = request.url if has_request_context():
record.remote_addr = request.remote_addr record.url = request.url
record.remote_addr = request.remote_addr
else:
record.url = None
record.remote_addr = None
return super().format(record) return super().format(record)
formatter = RequestFormatter( formatter = RequestFormatter(