maya-chen/flask
1
0
Fork 0
forked from orbit-oss/flask
Code Pull requests Activity

Fix registering partials as view functions

Browse source
This commit is contained in:
ThiefMaster 2018-04-27 13:38:35 +02:00
parent 8ceff653c5
commit 6663bf1f7d
3 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
CHANGES.rst
View file

@ -9,6 +9,7 @@ Version 1.0.1
unreleased unreleased
- Fix registering partials (with no ``__name__``) as view functions
Version 1.0 Version 1.0
----------- -----------

2
flask/blueprints.py
View file

@ -201,7 +201,7 @@ class Blueprint(_PackageBoundObject):
""" """
if endpoint: if endpoint:
assert '.' not in endpoint, "Blueprint endpoints should not contain dots" assert '.' not in endpoint, "Blueprint endpoints should not contain dots"
if view_func: if view_func and hasattr(view_func, '__name__'):
assert '.' not in view_func.__name__, "Blueprint view function name should not contain dots" assert '.' not in view_func.__name__, "Blueprint view function name should not contain dots"
self.record(lambda s: self.record(lambda s:
s.add_url_rule(rule, endpoint, view_func, **options)) s.add_url_rule(rule, endpoint, view_func, **options))

3
tests/test_blueprints.py
View file

@ -9,6 +9,7 @@
:license: BSD, see LICENSE for more details. :license: BSD, see LICENSE for more details.
""" """
import functools
import pytest import pytest
import flask import flask
@ -382,6 +383,8 @@ def test_route_decorator_custom_endpoint_with_dots(app, client):
) )
) )
bp.add_url_rule('/bar/456', endpoint='foofoofoo', view_func=functools.partial(foo_foo_foo))
app.register_blueprint(bp, url_prefix='/py') app.register_blueprint(bp, url_prefix='/py')
assert client.get('/py/foo').data == b'bp.foo' assert client.get('/py/foo').data == b'bp.foo'