maya-chen/flask
1
0
Fork 0
forked from orbit-oss/flask
Code Pull requests Activity

Fixed #1288: app.add_url_rule() should look for OPTIONS methods in a case-insensitive manner

Browse source
This commit is contained in:
Michael Hall 2014-12-24 11:16:57 -05:00
parent 413ae6137e
commit 98b155c65d
2 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/test_basic.py
View file

@ -107,15 +107,24 @@ def test_disallow_string_for_allowed_methods():
def test_url_mapping():
app = flask.Flask(__name__)
random_uuid4 = "7eb41166-9ebf-4d26-b771-ea3f54f8b383"
def index():
return flask.request.method
def more():
return flask.request.method
def options():
return random_uuid4
app.add_url_rule('/', 'index', index)
app.add_url_rule('/more', 'more', more, methods=['GET', 'POST'])
# Issue 1288: Test that automatic options are not added when non-uppercase 'options' in methods
app.add_url_rule('/options', 'options', options, methods=['options'])
c = app.test_client()
assert c.get('/').data == b'GET'
rv = c.post('/')
@ -129,6 +138,9 @@ def test_url_mapping():
rv = c.delete('/more')
assert rv.status_code == 405
assert sorted(rv.allow) == ['GET', 'HEAD', 'OPTIONS', 'POST']
rv = c.open('/options', method='OPTIONS')
assert rv.status_code == 200
assert random_uuid4 in rv.data.decode("utf-8")
def test_werkzeug_routing():