maya-chen/flask
1
0
Fork 0
forked from orbit-oss/flask
Code Pull requests Activity

Merge pull request #3498 from raymond-devries/3445-traceback-for-none

Browse source 
View returned none exception contains endpoint name
This commit is contained in:
David Lord 2020-02-10 13:15:24 -08:00 • committed by GitHub
commit a3e4395a42
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/flask/app.py
View file

@ -2078,9 +2078,9 @@ class Flask(_PackageBoundObject):
# the body must not be None # the body must not be None
if rv is None: if rv is None:
raise TypeError( raise TypeError(
"The view function did not return a valid response. The" 'The view function for "{}" did not return a valid response. The'
" function either returned None or ended without a return" " function either returned None or ended without a return"
" statement." " statement.".format(request.endpoint)
) )
# make sure the body is an instance of the response class # make sure the body is an instance of the response class

1
tests/test_basic.py
View file

@ -1221,6 +1221,7 @@ def test_response_type_errors():
with pytest.raises(TypeError) as e: with pytest.raises(TypeError) as e:
c.get("/none") c.get("/none")
assert "returned None" in str(e.value) assert "returned None" in str(e.value)
assert "from_none" in str(e.value)
with pytest.raises(TypeError) as e: with pytest.raises(TypeError) as e:
c.get("/small_tuple") c.get("/small_tuple")