maya-chen/flask
1
0
Fork 0
forked from orbit-oss/flask
Code Pull requests Activity

don't intercept 307/308 routing redirects

Browse source 
These don't change the request body, so the debug error is no longer relevant.
This commit is contained in:
David Lord 2022-03-23 08:25:22 -07:00
parent cb7cd1e79b
commit c9a1f7ad65
No known key found for this signature in database
GPG key ID: 7A1C87E3F5BC42A8
3 changed files with 45 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

30
tests/test_basic.py
View file

@ -15,6 +15,7 @@ from werkzeug.exceptions import Forbidden
from werkzeug.exceptions import NotFound
from werkzeug.http import parse_date
from werkzeug.routing import BuildError
from werkzeug.routing import RequestRedirect
import flask
@ -1724,28 +1725,29 @@ def test_before_first_request_functions_concurrent(app, client):
assert app.got_first_request
def test_routing_redirect_debugging(app, client):
app.debug = True
def test_routing_redirect_debugging(monkeypatch, app, client):
@app.route("/foo/", methods=["GET", "POST"])
def foo():
return "success"
with client:
with pytest.raises(AssertionError) as e:
client.post("/foo", data={})
assert "http://localhost/foo/" in str(e.value)
assert "Make sure to directly send your POST-request to this URL" in str(
e.value
)
rv = client.get("/foo", data={}, follow_redirects=True)
assert rv.data == b"success"
app.debug = False
rv = client.post("/foo", data={}, follow_redirects=True)
assert rv.data == b"success"
app.debug = True
with client:
rv = client.post("/foo", data={}, follow_redirects=True)
assert rv.data == b"success"
rv = client.get("/foo", data={}, follow_redirects=True)
assert rv.data == b"success"
monkeypatch.setattr(RequestRedirect, "code", 301)
with client, pytest.raises(AssertionError) as e:
client.post("/foo", data={})
assert "canonical URL 'http://localhost/foo/'" in str(e.value)
def test_route_decorator_custom_endpoint(app, client):