maya-chen/flask
1
0
Fork 0
forked from orbit-oss/flask
Code Pull requests Activity

Merge pull request #3574 from jackwardell/adding-error-message-to-assert

Browse source 
Adding error message to an assert
This commit is contained in:
David Lord 2020-04-16 10:52:06 -07:00 • committed by GitHub
commit d091bb00c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/flask/app.py
View file

@ -1270,7 +1270,9 @@ class Flask(_PackageBoundObject):
else: else:
exc_class = exc_class_or_code exc_class = exc_class_or_code
assert issubclass(exc_class, Exception) assert issubclass(
exc_class, Exception
), "Custom exceptions must be subclasses of Exception."
if issubclass(exc_class, HTTPException): if issubclass(exc_class, HTTPException):
return exc_class, exc_class.code return exc_class, exc_class.code

8
tests/test_user_error_handler.py
View file

@ -11,11 +11,19 @@ def test_error_handler_no_match(app, client):
class CustomException(Exception): class CustomException(Exception):
pass pass
class UnacceptableCustomException(BaseException):
pass
@app.errorhandler(CustomException) @app.errorhandler(CustomException)
def custom_exception_handler(e): def custom_exception_handler(e):
assert isinstance(e, CustomException) assert isinstance(e, CustomException)
return "custom" return "custom"
with pytest.raises(
AssertionError, match="Custom exceptions must be subclasses of Exception."
):
app.register_error_handler(UnacceptableCustomException, None)
@app.errorhandler(500) @app.errorhandler(500)
def handle_500(e): def handle_500(e):
assert isinstance(e, InternalServerError) assert isinstance(e, InternalServerError)