maya-chen/flask
1
0
Fork 0
forked from orbit-oss/flask
Code Pull requests Activity

Fix default index for TaggedJSONSerializer.register()

Browse source 
Change the default value of ``index`` to ``None`` in ``register()`` so
that it is possible to insert a new tag as the penultimate item in the
order list.
This commit is contained in:
Nick Pope 2018-04-19 13:55:37 +01:00
parent 16549370fd
commit fc6a1d9354
2 changed files with 20 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
flask/json/tag.py
View file

@ -243,7 +243,7 @@ class TaggedJSONSerializer(object):
for cls in self.default_tags:
self.register(cls)
def register(self, tag_class, force=False, index=-1):
def register(self, tag_class, force=False, index=None):
"""Register a new tag with this serializer.
:param tag_class: tag class to register. Will be instantiated with this
@ -251,8 +251,8 @@ class TaggedJSONSerializer(object):
:param force: overwrite an existing tag. If false (default), a
:exc:`KeyError` is raised.
:param index: index to insert the new tag in the tag order. Useful when
the new tag is a special case of an existing tag. If -1 (default),
the tag is appended to the end of the order.
the new tag is a special case of an existing tag. If ``None``
(default), the tag is appended to the end of the order.
:raise KeyError: if the tag key is already registered and ``force`` is
not true.
@ -266,7 +266,7 @@ class TaggedJSONSerializer(object):
self.tags[key] = tag
if index == -1:
if index is None:
self.order.append(tag)
else:
self.order.insert(index, tag)