adding in try around __import__ to catch invalid files/paths (#1950)
This commit is contained in:
parent
e6d7a43ccd
commit
0f1cf50f97
2 changed files with 9 additions and 1 deletions
|
|
@ -86,7 +86,13 @@ def locate_app(app_id):
|
|||
module = app_id
|
||||
app_obj = None
|
||||
|
||||
__import__(module)
|
||||
try:
|
||||
__import__(module)
|
||||
except ImportError:
|
||||
raise NoAppException('The file/path provided (%s) does not appear to '
|
||||
'exist. Please verify the path is correct. If '
|
||||
'app is not on PYTHONPATH, ensure the extension '
|
||||
'is .py' % module)
|
||||
mod = sys.modules[module]
|
||||
if app_obj is None:
|
||||
app = find_best_app(mod)
|
||||
|
|
|
|||
|
|
@ -80,6 +80,8 @@ def test_locate_app(test_apps):
|
|||
assert locate_app("cliapp.app").name == "testapp"
|
||||
assert locate_app("cliapp.app:testapp").name == "testapp"
|
||||
assert locate_app("cliapp.multiapp:app1").name == "app1"
|
||||
pytest.raises(NoAppException, locate_app, "notanpp.py")
|
||||
pytest.raises(NoAppException, locate_app, "cliapp/app")
|
||||
pytest.raises(RuntimeError, locate_app, "cliapp.app:notanapp")
|
||||
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue