orbit-oss/flask
4
4
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Switch from warnings.warn to logging.warning for dev server host check

Browse source 
Flask's test suite uses filterwarnings=['error'] in pyproject.toml,
which causes RuntimeWarning to fail tests. Using logging.warning()
preserves the security warning while avoiding test failures.
This commit is contained in:
zinc-builds 2026-05-11 00:48:16 +01:00
parent d1c7a30c80
commit 3529f0feb9
1 changed files with 6 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/flask/app.py
View file

@ -2,10 +2,10 @@ from __future__ import annotations
import collections.abc as cabc import collections.abc as cabc
import inspect import inspect
import logging
import os import os
import sys import sys
import typing as t import typing as t
import warnings
import weakref import weakref
from datetime import timedelta from datetime import timedelta
from functools import update_wrapper from functools import update_wrapper
@ -742,22 +742,19 @@ class Flask(App):
options.setdefault("threaded", True) options.setdefault("threaded", True)
if host not in {"127.0.0.1", "localhost", "::1"}: if host not in {"127.0.0.1", "localhost", "::1"}:
warnings.warn( logging.getLogger(__name__).warning(
f"The Flask development server is binding to '{host}', which " "The Flask development server is binding to '%s', which "
"makes it accessible on the network. The development server " "makes it accessible on the network. The development server "
"is not intended for production use and the Werkzeug debugger " "is not intended for production use and the Werkzeug debugger "
"can execute arbitrary code if exposed.", "can execute arbitrary code if exposed.",
RuntimeWarning, host,
stacklevel=2,
) )
if self.debug: if self.debug:
warnings.warn( logging.getLogger(__name__).warning(
"Debug mode is enabled while the development server is " "Debug mode is enabled while the development server is "
"accessible on the network. The Werkzeug debugger allows " "accessible on the network. The Werkzeug debugger allows "
"arbitrary code execution — do NOT use this configuration " "arbitrary code execution — do NOT use this configuration "
"in production or on untrusted networks.", "in production or on untrusted networks."
RuntimeWarning,
stacklevel=2,
) )
cli.show_server_banner(self.debug, self.name) cli.show_server_banner(self.debug, self.name)