From c6f55b5dbd1c5f08e56aa13b61b9b9912b5b4f21 Mon Sep 17 00:00:00 2001 From: Armin Ronacher Date: Sun, 25 Jul 2010 19:02:02 +0200 Subject: [PATCH 1/5] Consistency --- extreview/approved.rst | 8 ++++---- extreview/unlisted.rst | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/extreview/approved.rst b/extreview/approved.rst index a09aeb11..ea178ceb 100644 --- a/extreview/approved.rst +++ b/extreview/approved.rst @@ -11,8 +11,8 @@ Flask-Babel :First Approval: 2010-07-23 :Last Review: 2010-07-23 -:Approved version: 0.6 -:Approved license: BSD +:Approved Version: 0.6 +:Approved License: BSD Notes: Developed by the Flask development head @@ -24,8 +24,8 @@ Flask-SQLAlchemy :First Approval: 2010-07-25 :Last Review: 2010-07-25 -:Approved version: 0.9 -:Approved license: BSD +:Approved Version: 0.9 +:Approved License: BSD Notes: Developed by the Flask development head diff --git a/extreview/unlisted.rst b/extreview/unlisted.rst index 6168c912..6ee8b441 100644 --- a/extreview/unlisted.rst +++ b/extreview/unlisted.rst @@ -10,7 +10,7 @@ Flask-Actions ------------- :Last Review: 2010-07-25 -:Reviewed version: 0.2 +:Reviewed Version: 0.2 Rejected because of missing description in PyPI, formatting issues with the documentation (missing headlines, scrollbars etc.) and a general clash @@ -26,7 +26,7 @@ Flask-Jinja2Extender -------------------- :Last Review: 2010-07-25 -:Reviewed version: 0.1 +:Reviewed Version: 0.1 Usecase not obvious, hacky implementation, does not solve a problem that could not be solved with Flask itself. I suppose it is to aid other @@ -37,7 +37,7 @@ Flask-Markdown -------------- :Last Review: 2010-07-25 -:Reviewed version: 0.2 +:Reviewed Version: 0.2 Would be great for enlisting but it should follow the API of Flask-Creole. Besides that, the docstrings are not valid rst (run through rst2html to @@ -48,7 +48,7 @@ flask-urls ---------- :Last Review: 2010-07-25 -:Reviewed version: 0.9.2 +:Reviewed Version: 0.9.2 Broken PyPI index and non-conforming extension name. Due to the small featureset this was also delisted from the list. It was there previously From 385e67422ba1d590cf65e81dc7a85c916ada62e8 Mon Sep 17 00:00:00 2001 From: Armin Ronacher Date: Sun, 25 Jul 2010 19:44:08 +0200 Subject: [PATCH 2/5] Reviewed 0.9.1 :) --- extreview/approved.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extreview/approved.rst b/extreview/approved.rst index ea178ceb..96490063 100644 --- a/extreview/approved.rst +++ b/extreview/approved.rst @@ -24,7 +24,7 @@ Flask-SQLAlchemy :First Approval: 2010-07-25 :Last Review: 2010-07-25 -:Approved Version: 0.9 +:Approved Version: 0.9.1 :Approved License: BSD Notes: Developed by the Flask development head From e3f440d80ffedcc2adb0f058e06a3ee6c56710d9 Mon Sep 17 00:00:00 2001 From: Armin Ronacher Date: Sun, 25 Jul 2010 23:19:00 +0200 Subject: [PATCH 3/5] Approved Flask-Creole --- extreview/approved.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/extreview/approved.rst b/extreview/approved.rst index 96490063..526a181a 100644 --- a/extreview/approved.rst +++ b/extreview/approved.rst @@ -30,3 +30,15 @@ Flask-SQLAlchemy Notes: Developed by the Flask development head How to improve: add a better long description to the next release + + +Flask-Creole +------------ + +:First Approval: 2010-07-25 +:Last Review: 2010-07-25 +:Approved Version: 0.4.4 +:Approved License: BSD + +Notes: Flask-Markdown and this should share API, consider that when +approving Flask-Markdown From 54c126e7872b30dc9e5e28303eceea9e827e0231 Mon Sep 17 00:00:00 2001 From: Armin Ronacher Date: Sun, 25 Jul 2010 23:25:15 +0200 Subject: [PATCH 4/5] Removed Flask-Creole from the listed file, it's in approved already --- extreview/listed.rst | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/extreview/listed.rst b/extreview/listed.rst index cd658e92..a54c8a77 100644 --- a/extreview/listed.rst +++ b/extreview/listed.rst @@ -28,18 +28,6 @@ package (missing entry in MANIFEST.in) and the test suite does not respond to either "make test" or "python setup.py test". -Flask-Creole ------------- - -:Last-Review: 2010-07-25 -:Reviewed Version: 0.2 - -Would be fine for approval, but the test suite is not part of the sdist -package (missing entry in MANIFEST.in) and the test suite does not respond -to either "make test" or "python setup.py test". Furthermore the README -file is empty. - - flask-csrf ---------- From d455135338d84dfac2a2b98f52cde1d43dd87681 Mon Sep 17 00:00:00 2001 From: Armin Ronacher Date: Sun, 25 Jul 2010 23:46:24 +0200 Subject: [PATCH 5/5] Added a workaround for py.test --- tests/flaskext_test.py | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tests/flaskext_test.py b/tests/flaskext_test.py index 3614ad58..c7eb37df 100644 --- a/tests/flaskext_test.py +++ b/tests/flaskext_test.py @@ -216,13 +216,22 @@ def test_extension(name, interpreters, flask_dep): # figure out the test command and write a wrapper script. We # can't write that directly into the tox ini because tox does # not invoke the command from the shell so we have no chance - # to pipe the output into a logfile + # to pipe the output into a logfile. The /dev/null hack is + # to trick py.test (if used) into not guessing widths from the + # invoking terminal. test_command = get_test_command(checkout_path) log('Test command: %s', test_command) f = open(checkout_path + '/flaskext-runtest.sh', 'w') - f.write(test_command + ' &> "$1"\n') + f.write(test_command + ' &> "$1" < /dev/null\n') f.close() + # if there is a tox.ini, remove it, it will cause troubles + # for us. Remove it if present, we are running tox ourselves + # afterall. + toxini = os.path.join(checkout_path, 'tox.ini') + if os.path.isfile(toxini): + os.remove(toxini) + create_tox_ini(checkout_path, interpreters, flask_dep) rv = subprocess.call(['tox'], cwd=checkout_path) return TestResult(name, checkout_path, rv, interpreters)