From 45b2e7702dd76b11156c9b9b5af707be2b5480ca Mon Sep 17 00:00:00 2001 From: Diego Alberto Torres Quintanilla Date: Fri, 31 May 2019 14:54:03 -0400 Subject: [PATCH] Guard against missing request context in logging docs. --- docs/logging.rst | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/docs/logging.rst b/docs/logging.rst index 36ed7c85..937b2ae4 100644 --- a/docs/logging.rst +++ b/docs/logging.rst @@ -117,13 +117,18 @@ your own fields that can be used in messages. You can change the formatter for Flask's default handler, the mail handler defined above, or any other handler. :: - from flask import request + from flask import has_request_context, request from flask.logging import default_handler class RequestFormatter(logging.Formatter): def format(self, record): - record.url = request.url - record.remote_addr = request.remote_addr + if has_request_context(): + record.url = request.url + record.remote_addr = request.remote_addr + else: + record.url = None + record.remote_addr = None + return super().format(record) formatter = RequestFormatter(