orbit-oss/flask
4
4
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Check status code in test client or fail silently.

Browse source
This commit is contained in:
Ron DuPlain 2012-01-16 22:44:06 -05:00
parent b9907b4969
commit 676b3a4c13
1 changed files with 27 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

42
flask/testsuite/basic.py
View file

@ -319,7 +319,7 @@ class BasicFunctionalityTestCase(FlaskTestCase):
flask.flash(flask.Markup(u'<em>Testing</em>'), 'warning') flask.flash(flask.Markup(u'<em>Testing</em>'), 'warning')
return '' return ''
@app.route('/test') @app.route('/test/')
def test(): def test():
messages = flask.get_flashed_messages() messages = flask.get_flashed_messages()
self.assert_equal(len(messages), 3) self.assert_equal(len(messages), 3)
@ -328,7 +328,7 @@ class BasicFunctionalityTestCase(FlaskTestCase):
self.assert_equal(messages[2], flask.Markup(u'<em>Testing</em>')) self.assert_equal(messages[2], flask.Markup(u'<em>Testing</em>'))
return '' return ''
@app.route('/test_with_categories') @app.route('/test_with_categories/')
def test_with_categories(): def test_with_categories():
messages = flask.get_flashed_messages(with_categories=True) messages = flask.get_flashed_messages(with_categories=True)
self.assert_equal(len(messages), 3) self.assert_equal(len(messages), 3)
@ -337,14 +337,14 @@ class BasicFunctionalityTestCase(FlaskTestCase):
self.assert_equal(messages[2], ('warning', flask.Markup(u'<em>Testing</em>'))) self.assert_equal(messages[2], ('warning', flask.Markup(u'<em>Testing</em>')))
return '' return ''
@app.route('/test_filter') @app.route('/test_filter/')
def test_filter(): def test_filter():
messages = flask.get_flashed_messages(category_filter=['message'], with_categories=True) messages = flask.get_flashed_messages(category_filter=['message'], with_categories=True)
self.assert_equal(len(messages), 1) self.assert_equal(len(messages), 1)
self.assert_equal(messages[0], ('message', u'Hello World')) self.assert_equal(messages[0], ('message', u'Hello World'))
return '' return ''
@app.route('/test_filters') @app.route('/test_filters/')
def test_filters(): def test_filters():
messages = flask.get_flashed_messages(category_filter=['message', 'warning'], with_categories=True) messages = flask.get_flashed_messages(category_filter=['message', 'warning'], with_categories=True)
self.assert_equal(len(messages), 2) self.assert_equal(len(messages), 2)
@ -352,7 +352,7 @@ class BasicFunctionalityTestCase(FlaskTestCase):
self.assert_equal(messages[1], ('warning', flask.Markup(u'<em>Testing</em>'))) self.assert_equal(messages[1], ('warning', flask.Markup(u'<em>Testing</em>')))
return '' return ''
@app.route('/test_filters_without_returning_categories') @app.route('/test_filters_without_returning_categories/')
def test_filters(): def test_filters():
messages = flask.get_flashed_messages(category_filter=['message', 'warning']) messages = flask.get_flashed_messages(category_filter=['message', 'warning'])
self.assert_equal(len(messages), 2) self.assert_equal(len(messages), 2)
@ -360,21 +360,33 @@ class BasicFunctionalityTestCase(FlaskTestCase):
self.assert_equal(messages[1], flask.Markup(u'<em>Testing</em>')) self.assert_equal(messages[1], flask.Markup(u'<em>Testing</em>'))
return '' return ''
# Note: if status code assertions are missing, failed tests still pass.
#
# Since app.test_client() does not set debug=True, the AssertionErrors
# in the view functions are swallowed and the only indicator is a 500
# status code.
#
# Also, create new test client on each test to clean flashed messages.
c = app.test_client() c = app.test_client()
c.get('/') # Flash some messages. c.get('/')
c.get('/test') assert c.get('/test/').status_code == 200
c.get('/') # Flash more messages. c = app.test_client()
c.get('/test_with_categories') c.get('/')
assert c.get('/test_with_categories/').status_code == 200
c.get('/') # Flash more messages. c = app.test_client()
c.get('/test_filter') c.get('/')
assert c.get('/test_filter/').status_code == 200
c.get('/') # Flash more messages. c = app.test_client()
c.get('/test_filters') c.get('/')
assert c.get('/test_filters/').status_code == 200
c.get('/') # Flash more messages. c = app.test_client()
c.get('/test_filters_without_returning_categories') c.get('/')
assert c.get('/test_filters_without_returning_categories/').status_code == 200
def test_request_processing(self): def test_request_processing(self):
app = flask.Flask(__name__) app = flask.Flask(__name__)