clean up open_resource and tests

This commit is contained in:
David Lord 2019-05-17 13:20:31 -07:00
parent ad709be46e
commit 6f703a564c
No known key found for this signature in database
GPG key ID: 7A1C87E3F5BC42A8
3 changed files with 13 additions and 21 deletions

View file

@ -1053,12 +1053,12 @@ class _PackageBoundObject(object):
:param resource: the name of the resource. To access resources within
subfolders use forward slashes as separator.
:param mode: resource file opening mode, default is 'rb'.
:param mode: Open file in this mode. Only reading is supported,
valid values are "r" (or "rt") and "rb".
"""
if mode == 'rt':
mode = 'r'
if mode not in ("r", "rb"):
if mode not in {"r", "rt", "rb"}:
raise ValueError("Resources can only be opened for reading")
return open(os.path.join(self.root_path, resource), mode)