orbit-oss/is
5
5
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix #109: is.numericString behaves correctly on whitespaces (#110)

Browse source
This commit is contained in:
Arfat Salman 2020-04-18 03:25:02 +05:30 • committed by GitHub
parent 05cdaccf92
commit 402fbb5a7e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
source/index.ts
View file

@ -130,7 +130,7 @@ is.boolean = (value: unknown): value is boolean => value === true || value === f
is.symbol = isOfType<symbol>('symbol');
is.numericString = (value: unknown): value is string =>
is.string(value) && value.length > 0 && !Number.isNaN(Number(value));
is.string(value) && !is.emptyStringOrWhitespace(value) && !Number.isNaN(Number(value));
is.array = Array.isArray;
is.buffer = (value: unknown): value is Buffer => (value as any)?.constructor?.isBuffer?.(value) ?? false;

5
test/test.ts
View file

@ -124,7 +124,8 @@ const types = new Map<string, Test>([
fixtures: [
'5',
'-3.2',
'Infinity'
'Infinity',
'0x56'
],
typename: TypeName.string,
typeDescription: AssertionTypeDescription.numericString
@ -627,6 +628,8 @@ test('is.symbol', t => {
test('is.numericString', t => {
testType(t, 'numericString');
t.false(is.numericString(''));
t.false(is.numericString(' '));
t.false(is.numericString(' \t\t\n'));
t.false(is.numericString(1));
t.throws(() => {
assert.numericString('');