From 576dc745bbe75fab8b5d04340a7e31f3c7193b80 Mon Sep 17 00:00:00 2001 From: Lukas Tetzlaff Date: Thu, 1 Nov 2018 20:52:03 +0100 Subject: [PATCH] Change `numericString` to use `unknown` as parameter signature and add `object` typed keys for collections --- source/index.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/source/index.ts b/source/index.ts index 9e9d77b..8b52bc1 100644 --- a/source/index.ts +++ b/source/index.ts @@ -137,7 +137,7 @@ namespace is { // tslint:disable-line:no-namespace export const symbol = isOfType('symbol'); // tslint:enable:variable-name - export const numericString = (value: any): boolean => + export const numericString = (value: unknown): boolean => string(value) && value.length > 0 && !Number.isNaN(Number(value)); export const array = Array.isArray; @@ -169,8 +169,8 @@ namespace is { // tslint:disable-line:no-namespace export const error = isObjectOfType(TypeName.Error); export const map = (value: unknown): value is Map => isObjectOfType>(TypeName.Map)(value); export const set = (value: unknown): value is Set => isObjectOfType>(TypeName.Set)(value); - export const weakMap = (value: unknown): value is WeakMap => isObjectOfType>(TypeName.WeakMap)(value); - export const weakSet = (value: unknown): value is WeakSet => isObjectOfType>(TypeName.WeakSet)(value); + export const weakMap = (value: unknown): value is WeakMap => isObjectOfType>(TypeName.WeakMap)(value); + export const weakSet = (value: unknown): value is WeakSet => isObjectOfType>(TypeName.WeakSet)(value); export const int8Array = isObjectOfType(TypeName.Int8Array); export const uint8Array = isObjectOfType(TypeName.Uint8Array);