orbit-oss/is
5
5
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor is.domElement to declare constants outside the function

Browse source
This commit is contained in:
Melvin Philips 2017-10-05 14:17:39 -07:00
parent b22d9e88db
commit 718a216797
2 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
index.js
View file

@ -161,11 +161,12 @@ is.inRange = (x, range) => {
throw new TypeError(`Invalid range: ${util.inspect(range)}`); throw new TypeError(`Invalid range: ${util.inspect(range)}`);
}; };
const NODE_TYPE_ELEMENT_NODE = 1;
const DOM_PROPERTIES_TO_CHECK = ['innerHTML', 'ownerDocument', 'style', 'attributes', 'nodeValue'];
is.domElement = x => { is.domElement = x => {
const ELEMENT_NODE = 1; return is.object(x) && x.nodeType === NODE_TYPE_ELEMENT_NODE && is.string(x.nodeName) &&
const propsToCheck = ['innerHTML', 'ownerDocument', 'style', 'attributes', 'nodeValue']; !is.plainObject(x) && DOM_PROPERTIES_TO_CHECK.every(property => property in x);
return is.object(x) && x.nodeType === ELEMENT_NODE && is.string(x.nodeName) &&
!is.plainObject(x) && propsToCheck.every(prop => prop in x);
}; };
is.infinite = x => x === Infinity || x === -Infinity; is.infinite = x => x === Infinity || x === -Infinity;

7
test.js
View file

@ -9,6 +9,7 @@ const PromiseSubclassFixture = class extends Promise {};
const ErrorSubclassFixture = class extends Error {}; const ErrorSubclassFixture = class extends Error {};
const document = jsdom(); const document = jsdom();
const createDomElement = el => document.createElement(el);
const types = new Map([ const types = new Map([
['undefined', undefined], ['undefined', undefined],
@ -93,12 +94,14 @@ const types = new Map([
new Object() // eslint-disable-line no-new-object new Object() // eslint-disable-line no-new-object
]], ]],
['integer', 6], ['integer', 6],
['domElement', ['div', ['domElement', [
'div',
'input', 'input',
'span', 'span',
'img', 'img',
'canvas', 'canvas',
'script'].map(el => document.createElement(el))], 'script'
].map(createDomElement)],
['non-domElements', [ ['non-domElements', [
document.createTextNode('data'), document.createTextNode('data'),
document.createProcessingInstruction('xml-stylesheet', 'href="mycss.css" type="text/css"'), document.createProcessingInstruction('xml-stylesheet', 'href="mycss.css" type="text/css"'),