orbit-oss/is
5
5
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove every spread operator

Browse source 
Either using the code from before the ts-refactors or writing something that will match both our runtime targets and still provides type/ide support by using type overloads
This commit is contained in:
Lukas Tetzlaff 2017-11-03 23:21:53 +01:00
parent 4670dcf33e
commit 987972854e
1 changed files with 20 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

29
source/index.ts
View file

@ -166,7 +166,8 @@ namespace is { // tslint:disable-line:no-namespace
} }
if (array(range) && range.length === 2) { if (array(range) && range.length === 2) {
return value >= Math.min(...range) && value <= Math.max(...range); // TODO: Use spread operator here when targeting Node.js 6 or higher
return value >= Math.min.apply(null, range) && value <= Math.max.apply(null, range);
} }
throw new TypeError(`Invalid range: ${util.inspect(range)}`); throw new TypeError(`Invalid range: ${util.inspect(range)}`);
@ -199,7 +200,12 @@ namespace is { // tslint:disable-line:no-namespace
export const emptyOrWhitespace = (value: any) => empty(value) || isWhiteSpaceString(value); export const emptyOrWhitespace = (value: any) => empty(value) || isWhiteSpaceString(value);
type ArrayMethod = (fn: (value: any, index: number, arr: any[]) => boolean, thisArg?: any) => boolean; type ArrayMethod = (fn: (value: any, index: number, arr: any[]) => boolean, thisArg?: any) => boolean;
const predicateOnArray = (method: ArrayMethod, predicate: any, values: any[]) => { const predicateOnArray = (method: ArrayMethod, predicate: any, args: IArguments) => {
// `args` is the calling function's "arguments object".
// We have to do it this way to keep node v4 support.
// So here we convert it to an array and slice off the first item.
const values = Array.prototype.slice.call(args, 1);
if (function_(predicate) === false) { if (function_(predicate) === false) {
throw new TypeError(`Invalid predicate: ${util.inspect(predicate)}`); throw new TypeError(`Invalid predicate: ${util.inspect(predicate)}`);
} }
@ -211,14 +217,19 @@ namespace is { // tslint:disable-line:no-namespace
return method.call(values, predicate); return method.call(values, predicate);
}; };
// tslint:disable-next-line:variable-name // We can't use rest parameters in node v4 due to the lack of the spread operator.
export const any = (predicate: any, ...values: any[]) => { // Therefore We have to use anonymous functions for the any() and all() methods
return predicateOnArray(Array.prototype.some, predicate, values); // tslint:disable:only-arrow-functions no-function-expression
}; export function any(...predicate: any[]): any; // tslint:disable-line:variable-name
export function any(predicate: any) {
return predicateOnArray(Array.prototype.some, predicate, arguments);
}
export const all = (predicate: any, ...values: any[]) => { export function all(...predicate: any[]): any;
return predicateOnArray(Array.prototype.every, predicate, values); export function all(predicate: any) {
}; return predicateOnArray(Array.prototype.every, predicate, arguments);
}
// tslint:enable:only-arrow-functions no-function-expression
} }
// Some few keywords are reserved, but we'll populate them for the node-folks // Some few keywords are reserved, but we'll populate them for the node-folks