From c15534f9d57225a84b55e7a65bb8e2d3e33d3e3c Mon Sep 17 00:00:00 2001 From: Adam Babcock Date: Fri, 19 Apr 2019 12:30:13 -0500 Subject: [PATCH] PR feedback --- test/test.ts | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/test/test.ts b/test/test.ts index dd97cdf..479a028 100644 --- a/test/test.ts +++ b/test/test.ts @@ -801,12 +801,19 @@ test('is.domElement', t => { testType(t, 'domElement'); t.false(is.domElement({nodeType: 1, nodeName: 'div'})); - t.is(is(createDomElement('div')), 'HTMLDivElement'); - t.is(is(createDomElement('input')), 'HTMLInputElement'); - t.is(is(createDomElement('span')), 'HTMLSpanElement'); - t.is(is(createDomElement('img')), 'HTMLImageElement'); - t.is(is(createDomElement('canvas')), 'HTMLCanvasElement'); - t.is(is(createDomElement('script')), 'HTMLScriptElement'); + const htmlTagNameToTypeName = { + div: 'HTMLDivElement', + input: 'HTMLInputElement', + span: 'HTMLSpanElement', + img: 'HTMLImageElement', + canvas: 'HTMLCanvasElement', + script: 'HTMLScriptElement' + }; + + Object.entries(htmlTagNameToTypeName).forEach(([tagName, typeName]) => { + const domElement = createDomElement(tagName); + t.is(is(domElement), typeName); + }); }); test('is.observable', t => {