ravi-patel/flask
1
0
Fork 0
forked from orbit-oss/flask
Code Pull requests Activity

Fix 0 port value being overriden by default

Browse source 
By explicitly comparing port value with None,
instead of using its bool() value.
This commit is contained in:
vorelq 2018-09-29 18:38:32 +02:00 • committed by David Lord
parent 05102f63b8
commit e1cc16f8be
No known key found for this signature in database
GPG key ID: 7A1C87E3F5BC42A8
3 changed files with 14 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tests/test_basic.py
View file

@ -1916,21 +1916,24 @@ def test_run_server_port(monkeypatch, app):
@pytest.mark.parametrize(
"host,port,expect_host,expect_port",
"host,port,server_name,expect_host,expect_port",
(
(None, None, "pocoo.org", 8080),
("localhost", None, "localhost", 8080),
(None, 80, "pocoo.org", 80),
("localhost", 80, "localhost", 80),
(None, None, "pocoo.org:8080", "pocoo.org", 8080),
("localhost", None, "pocoo.org:8080", "localhost", 8080),
(None, 80, "pocoo.org:8080", "pocoo.org", 80),
("localhost", 80, "pocoo.org:8080", "localhost", 80),
("localhost", 0, "localhost:8080", "localhost", 0),
(None, None, "localhost:8080", "localhost", 8080),
(None, None, "localhost:0", "localhost", 0),
),
)
def test_run_from_config(monkeypatch, host, port, expect_host, expect_port, app):
def test_run_from_config(monkeypatch, host, port, server_name, expect_host, expect_port, app):
def run_simple_mock(hostname, port, *args, **kwargs):
assert hostname == expect_host
assert port == expect_port
monkeypatch.setattr(werkzeug.serving, "run_simple", run_simple_mock)
app.config["SERVER_NAME"] = "pocoo.org:8080"
app.config["SERVER_NAME"] = server_name
app.run(host, port)